Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] WSNM Quest Fix #6854

Merged
merged 1 commit into from
Jan 26, 2025
Merged

[Lua] WSNM Quest Fix #6854

merged 1 commit into from
Jan 26, 2025

Conversation

dallano
Copy link
Contributor

@dallano dallano commented Jan 26, 2025

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • x ] I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Fixes a possible exploit in the quest logic that could allow players to bypass "breaking" their weapons if someone else were to spawn the NM. Added logic to ensure the player has the key item required

Steps to test these changes

Pop NM according to the quest as a player ready to fight NM.
Be present on a second character with the quest just freshly started.
Kill NM
Witness second character can complete quest.

Fixes a possible exploit in the quest logic that could allow players to bypass "breaking" their weapons if someone else were to spawn the NM.
Added logic to ensure the player has the key item required
@dallano dallano changed the title [Lua] WSNM Quest Exploit Fix [Lua] WSNM Quest Fix Jan 26, 2025
@LandSandBoat LandSandBoat deleted a comment from github-actions bot Jan 26, 2025
@zach2good zach2good merged commit 57ebae0 into LandSandBoat:base Jan 26, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants